This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Websocket connection undefined #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite/ganache-core into websocket-connection-undefined
This was referenced Dec 17, 2018
davidmurdoch
approved these changes
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you attempt a subscription, such as:
eth_subscribe "pendingTransactions"via a ganache http server it will accept and subscribe your http connection to all future"pendingTransactions". If a client issues a subsequenteth_sendTransaction, ourwebsocketServerwill try to get that subscription it's message (over a connection that doesn't exist) and crash ganache-cli in the process.This PR explicitly checks and rejects subscriptions over http. In addition, we add a safety check in the websocketServer if it attempts to respond to a non-existent connection.